Lei Li has posted comments on this change. Change subject: Move and encapsulate preun section into vdsm-tool ......................................................................
Patch Set 4: (6 inline comments) .................................................... File vdsm/constants.py.in Line 71: # Configuration file definitions These constants were defined because I found that they will also be used by the patch re-coding vdsmd.in from WenYi Gao. If you still think it's useless, I will git rid of them in next set. .................................................... File vdsm.spec.in Line 400: # Stop vdsm service Oh.. my mistake here..! Line 412: # Restore libvirt service OK .................................................... File vdsm-tool/unregister.py Line 26: BY_VDSM = '# by vdsm' 'feature parity'? Sorry I don't quiet understand here, since I just recode it based on the spec file. Do you mean check by different version? Sure, I will add test cases for this patch later. Line 51: def __remove_from_file(fileName, begin=None, end=None): Do you mean the name of this function should be change? Sure, I will add unit test later. Line 72: f.writelines(newfile) Yes, you are right. I will modify it follow the 'atomic move trick' way. BTW: what's the 'ovirt-node' case? Can I find mburns on IRC? -- To view, visit http://gerrit.ovirt.org/4526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e7b5dc969dfb51e6880b9bb209a363609f5e123 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li <li...@linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <a...@us.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Lei Li <li...@linux.vnet.ibm.com> Gerrit-Reviewer: Ryan Harper <ry...@us.ibm.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
