Lei Li has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm-tool/unregister.py
Line 26: BY_VDSM = '# by vdsm'
Hi Dan,
I just look at the file vdsmd.init.in, seems these key words for config are no
long just '# by vdsm', changed to:
by_vdsm="by vdsm"
by_vdsm_vers="4.9.6"
start_conf_section="## beginning of configuration section ${by_vdsm}"
end_conf_section="## end of configuration section ${by_vdsm}"
As for my reply to your comment on constants I added, how about define all of
these field to constants? Then:
1) The patch about move vdsmd.init.in into vdsm-tool can also reuse it.
2) Whenever change the flag field for vdsm config, just modify the constants we
defined.
So what's your opinion?
--
To view, visit http://gerrit.ovirt.org/4526
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e7b5dc969dfb51e6880b9bb209a363609f5e123
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <li...@linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <a...@us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Lei Li <li...@linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ry...@us.ibm.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
