Roman Fenkhuber has posted comments on this change. Change subject: Basic tests for the tc module ......................................................................
Patch Set 9: (2 inline comments) So now this should be it. It turned out, that patch 8 did not work if the pc had no IP assigned on any interface and that it also failed on kernels > 3.4 (fc17). It is now tested on 2.6.35, 3.3.8 and 3.4.4. Thanks for your patience. .................................................... File tests/tcTests.py Line 69: check_call([EXT_BRCTL, 'setfd', self.devName, '0']) kernels 2.x need this, kernels 3.x hate this. Line 203: self._tap0.addDevice(self._SUBNET) I know, it is some kind of step back, but it is necessary to make "offline" testing possible. -- To view, visit http://gerrit.ovirt.org/6225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee9437d1b5a96b3896df157f13888485ae7292d2 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roman Fenkhuber <ro...@fenkhuber.at> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Roman Fenkhuber <ro...@fenkhuber.at> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
