Dan Kenigsberg has posted comments on this change.
Change subject: Basic tests for the tc module
......................................................................
Patch Set 12: I would prefer that you didn't submit this
(2 inline comments)
relatively minor comments. thanks.
....................................................
File tests/tcTests.py
Line 128: def CheckDependencies(f):
why a leading Upper case to a function?
and frankly, I do not understand the grand benefit of a decorator in this
case... it could have been a bit simpler if a local function had been run by
setUp. but that's mostly a matter of taste.
Line 143: raise SkipTest("Traffic Control kernel modules are not
installed.")
I'd like to be more exact, and say something like
"'tc' has failed. Do you have Traffic Control kernel modules are not installed?"
tc may fail for other reasons.
--
To view, visit http://gerrit.ovirt.org/6225
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee9437d1b5a96b3896df157f13888485ae7292d2
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Fenkhuber <ro...@fenkhuber.at>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Roman Fenkhuber <ro...@fenkhuber.at>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
