Dan Kenigsberg has posted comments on this change. Change subject: Basic tests for the tc module ......................................................................
Patch Set 10: I would prefer that you didn't submit this (2 inline comments) minor comments, this version is a cool improvement. .................................................... File tests/tcTests.py Line 40: EXT_TCPDUMP = "/usr/sbin/tcpdump" I understand the coolness factor of working directly from python. now that tcpdump and ping fell into disuse, we should remove them. Line 217: packet = ''.join(map(lambda x: chr(int(x[0] + x[1], 16)), aren't you re-inventing binascii.unhexlify ? -- To view, visit http://gerrit.ovirt.org/6225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee9437d1b5a96b3896df157f13888485ae7292d2 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roman Fenkhuber <ro...@fenkhuber.at> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Roman Fenkhuber <ro...@fenkhuber.at> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
