Irit Goihman has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator ......................................................................
Patch Set 10: (6 comments) https://gerrit.ovirt.org/#/c/53214/7/lib/vdsm/module_utils.py File lib/vdsm/module_utils.py: PS7, Line 2: > remove Done PS7, Line 28: > load_modules Done PS7, Line 32: : : > How about this? Done PS7, Line 35: : > We need a more general behavior, I'm still looking at places in the project Done https://gerrit.ovirt.org/#/c/53214/7/lib/vdsm/tool/configurators/__init__.py File lib/vdsm/tool/configurators/__init__.py: Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # Line 20: Line 21: from __future__ import absolute_import Line 22: from vdsm.tool import UsageError > It is preferred to do these type of changes changes in a separated patch, p Done Line 23: Line 24: Line 25: class InvalidConfig(UsageError): Line 26: """ raise when invalid configuration passed """ https://gerrit.ovirt.org/#/c/53214/7/tests/module_utils_tests.py File tests/module_utils_tests.py: PS7, Line 47: : : : : > We better not have print/s in a test. Done -- To view, visit https://gerrit.ovirt.org/53214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
