Yaniv Bronhaim has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator ......................................................................
Patch Set 12: (3 comments) except some minor notes its +1 https://gerrit.ovirt.org/#/c/53214/12/lib/vdsm/Makefile.am File lib/vdsm/Makefile.am: Line 46: logUtils.py \ Line 47: m2cutils.py \ Line 48: machinetype.py \ Line 49: momIF.py \ Line 50: module_loader.py \ I think m is after d Line 51: netconfpersistence.py \ Line 52: numa.py \ Line 53: osinfo.py \ Line 54: panic.py \ https://gerrit.ovirt.org/#/c/53214/12/tests/module_loader_test.py File tests/module_loader_test.py: Line 39: def test_import_modules(self, files, expected_modules): Line 40: with namedTemporaryDir() as path: Line 41: for f in files: Line 42: utils.touchFile(os.path.join(path, f)) Line 43: utils.touchFile(os.path.join(path, '__init__.py')) you can touch __init__.py only once Line 44: result = module_loader.load_modules(path) Line 45: Line 46: result = frozenset(result.keys()) Line 47: expected = frozenset(expected_modules) https://gerrit.ovirt.org/#/c/53214/12/vdsm.spec.in File vdsm.spec.in: Line 1120: %{python_sitelib}/%{vdsm_name}/kernelconfig.py* Line 1121: %{python_sitelib}/%{vdsm_name}/libvirtconnection.py* Line 1122: %{python_sitelib}/%{vdsm_name}/logUtils.py* Line 1123: %{python_sitelib}/%{vdsm_name}/m2cutils.py* Line 1124: %{python_sitelib}/%{vdsm_name}/machinetype.py* should be here Line 1125: %{python_sitelib}/%{vdsm_name}/momIF.py* Line 1126: %{python_sitelib}/%{vdsm_name}/netinfo/__init__.py* Line 1127: %{python_sitelib}/%{vdsm_name}/netinfo/addresses.py* Line 1128: %{python_sitelib}/%{vdsm_name}/netinfo/bonding.py* -- To view, visit https://gerrit.ovirt.org/53214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
