Nir Soffer has posted comments on this change. Change subject: cdrom: API change: require interface & index ......................................................................
Patch Set 2: (3 comments) Adding Piotr to review the schema changes. https://gerrit.ovirt.org/#/c/56805/2/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json: Line 6473 Line 6474 Line 6475 Line 6476 Line 6477 We should add 'str' to this list, as this is the real way engine is using this api, and we don't want type verification warnings when working with old engines. Line 6476: 'union': ['DriveSpecVolume', 'DriveSpecGUID', 'DriveSpecPayload', Line 6477: 'DriveSpecPath']} Line 6478: Line 6479: ## Line 6480: # @CdromSpec: Dan has interesting point - DriveSpec may be only about the source (file, block device, etc.), not about the target (bus, interface, etc.) So we may not need to add new type DriveSpec. Line 6481: # Line 6482: # A cdrom specification that allows directly indexing the cdrom. Line 6483: # Line 6484: # @driveSpec: The specification of the new CD Line 6506: # Line 6507: # Since: 4.10.0 Line 6508: ## Line 6509: {'command': {'class': 'VM', 'name': 'changeCD'}, Line 6510: 'data': {'vmID': 'UUID', 'driveSpec': 'CdromSpec'}, The current schema is wrong, engine send a string "/path/to/cdrom", instead of {"path": "/path/to/cdrom"}. So we need to fix the schema - see my comment in @DriveSpec. Line 6511: 'returns': 'VmDefinition'} Line 6512: Line 6513: ## Line 6514: # @VM.changeFloppy: -- To view, visit https://gerrit.ovirt.org/56805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I178c1a02bbad962f9dc9b67bed7691cf170ee896 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
