Edward Haas has posted comments on this change. Change subject: net: OVS Info ......................................................................
Patch Set 15: (3 comments) https://gerrit.ovirt.org/#/c/56901/15/lib/vdsm/network/ovs/info.py File lib/vdsm/network/ovs/info.py: PS15, Line 33: driver_instance ovsdb Line 44: self.ports = ports_command.result Line 45: self.ifaces = ifaces_command.result Line 46: Line 47: Line 48: def _uuids_to_names(uuids, entries_uuids): Only one usage... you can convert it to a list comprehension at the caller. Line 49: names = [] Line 50: for uuid in uuids: Line 51: names.append(entries_uuids[uuid]['name']) Line 52: return names PS15, Line 73: ports = {port['name']: self._port_attr(port['_uuid']) : for port in self._ovs_db.ports} Better move it to the __init__ method to avoid kipping _ovs_db at the instance level, it can become localized. (Not sure if you can do it nicely) But I also think the ports need to be limited to the ones belonging to this specific bridge... right? -- To view, visit https://gerrit.ovirt.org/56901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
