Edward Haas has posted comments on this change. Change subject: net: OVS Info ......................................................................
Patch Set 17: (2 comments) partial review.. https://gerrit.ovirt.org/#/c/56901/16/lib/vdsm/network/ovs/info.py File lib/vdsm/network/ovs/info.py: PS16, Line 64: [self._ports_uuids[uuid] : for uuid in bridge['ports']] I think you can move it to _bridge_attr method. PS16, Line 70: port['_uuid'] Can you send here the 'port'? Seems like you send the uuid of the port, just to ask for the port entry back... -- To view, visit https://gerrit.ovirt.org/56901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
