Petr Horáček has posted comments on this change. Change subject: net: OVS Info ......................................................................
Patch Set 16: Verified+1 (3 comments) Passed ovs_info_test.py. Added sleep(1) before setting IP, because it was not able to find created interface on Jenkins. https://gerrit.ovirt.org/#/c/56901/15/lib/vdsm/network/ovs/info.py File lib/vdsm/network/ovs/info.py: PS15, Line 33: ovsdb): > ovsdb Done Line 44: self.ports = ports_command.result Line 45: self.ifaces = ifaces_command.result Line 46: Line 47: Line 48: class OvsInfo(object): > Only one usage... you can convert it to a list comprehension at the caller. Done Line 49: def __init__(self): Line 50: ovs_db = OvsDB(driver.create()) Line 51: self._ports_uuids = {port['_uuid']: port Line 52: for port in ovs_db.ports} PS15, Line 73: return {'ports': ports, 'stp': stp} : > Better move it to the __init__ method to avoid kipping _ovs_db at the insta Done -- To view, visit https://gerrit.ovirt.org/56901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
