Martin Polednik has posted comments on this change. Change subject: cdrom: API change: require interface & index ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/56805/2/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json: Line 6473 Line 6474 Line 6475 Line 6476 Line 6477 > We cannot fix old engines, they will continue to access vdsm with a string. Sounds reasonable, should be handled in separate patch (as it's not related to this change). https://gerrit.ovirt.org/#/c/56805/2/vdsm/virt/vm.py File vdsm/virt/vm.py: PS2, Line 3820: TypeError > Please narrow down this block as much as you can. I believe only line 3817 Afaik right. -- To view, visit https://gerrit.ovirt.org/56805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I178c1a02bbad962f9dc9b67bed7691cf170ee896 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
