Nir Soffer has posted comments on this change. Change subject: cdrom: API change: require interface & index ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/56805/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3864: "Action: %s", self.name, Line 3865: actionToString(action)) Line 3866: Line 3867: def changeCD(self, cdromspec): Line 3868: if isinstance(cdromspec, str): Nice! But we actually get unicode object - you want to use: if isinstance(cdromspec, basestring): Line 3869: # < 4.0 - known cdrom interface/index Line 3870: drivespec = cdromspec Line 3871: if cpuarch.is_ppc(self.arch): Line 3872: blockdev = 'sda' -- To view, visit https://gerrit.ovirt.org/56805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I178c1a02bbad962f9dc9b67bed7691cf170ee896 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
