Adam Litke has posted comments on this change. Change subject: qemuimg: Move wait_for_completion inside QemuImgOperation ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/60691/1/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 186: return QemuImgOperation(cmd, cwd=cwdPath) Line 187: Line 188: Line 189: class QemuImgOperation(object): Line 190: log = logging.getLogger() > Why do you need a the root logger here? I don't. Removing. Line 191: REGEXPR = re.compile(r'\s*\(([\d.]+)/100%\)\s*') Line 192: Line 193: def __init__(self, cmd, cwd=None): Line 194: self._aborted = False -- To view, visit https://gerrit.ovirt.org/60691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95075798022e67b0d1e63e7f7677ba0f84c2b328 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org