Nir Soffer has posted comments on this change. Change subject: qemuimg: Move wait_for_completion inside QemuImgOperation ......................................................................
Patch Set 3: Code-Review+2 (1 comment) Thanks https://gerrit.ovirt.org/#/c/60691/3/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 261: def wait_for_completion(self): Line 262: timeout = config.getint("irs", "progress_interval") Line 263: while not self.finished: Line 264: self.poll(timeout) Line 265: _log.debug('qemu-img operation progress: %s%%', self.progress) It would be nice to have a test for this - probably monkeypatching the config to use 0.1 seconds interval and running couple of cycles. Line 266: Line 267: def abort(self): Line 268: if self._command.poll() is None: Line 269: self._aborted = True -- To view, visit https://gerrit.ovirt.org/60691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95075798022e67b0d1e63e7f7677ba0f84c2b328 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
