Nir Soffer has posted comments on this change. Change subject: qemuimg: Move wait_for_completion inside QemuImgOperation ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/60691/1/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 231: raise ValueError('Unable to parse: "%r"' % last_progress) Line 232: Line 233: self._progress = float(m.group(1)) Line 234: Line 235: def _poll(self, timeout=None): > It's confusing to have wait and wait_for_completion as public interfaces in I disagree, please separate these changes to another patch if you think they are needed. Line 236: self._stream.receive(timeout=timeout) Line 237: Line 238: if not self._stream.closed: Line 239: return -- To view, visit https://gerrit.ovirt.org/60691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95075798022e67b0d1e63e7f7677ba0f84c2b328 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
