Ramesh N has posted comments on this change. Change subject: gluster: set selinux labels while creating bricks ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/62773/2/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 321: Line 322: rc, out, err = commands.execCmd([_restoreconCommandPath.cmd, Line 323: '-Rv', mountPoint]) Line 324: if rc: Line 325: raise ge.GlusterHostFailedToRunRestorecon(mountPoint, rc, out, err) > should brick creation fail on failure to set selinux context? Good point. Is there way to tell the user that selinux labels where not set correctly. Note: at this stage, brick is created and mounted but the /etc/fstab entry and selinux labels are missing. Line 326: Line 327: # bz#1230495: lvm devices are invisible and appears only after vgscan Line 328: # Workaround: Till the bz gets fixed, We use vgscan to refresh LVM devices Line 329: rc, out, err = commands.execCmd([_vgscanCommandPath.cmd]) -- To view, visit https://gerrit.ovirt.org/62773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
