Adam Litke has posted comments on this change. Change subject: storage: Report generation id in volume.getInfo ......................................................................
Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/64485/1/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: Line 6962: - description: The status of the Volume lease Line 6963: name: lease Line 6964: type: *VolumeLeaseStatus Line 6965: Line 6966: - description: A monotonically increasing generation id > How about: Done Line 6967: name: generation Line 6968: type: uint Line 6969: type: object Line 6970: Line 6964: type: *VolumeLeaseStatus Line 6965: Line 6966: - description: A monotonically increasing generation id Line 6967: name: generation Line 6968: type: uint > long long? int64_t? these are keywords in the schema. I don't think we have anything more specific than uint. Java can use int64_t if it wants to use it. Line 6969: type: object Line 6970: Line 6971: VolumeSizeInfo: &VolumeSizeInfo Line 6972: added: '3.1' https://gerrit.ovirt.org/#/c/64485/1/vdsm/storage/volume.py File vdsm/storage/volume.py: Line 205: "image": self.getImage(), Line 206: "ctime": meta.get(sc.CTIME, ""), Line 207: "mtime": "0", Line 208: "legality": meta.get(sc.LEGALITY, ""), Line 209: "generation": meta.get(sc.GENERATION, 0) > We have this in several places, maybe we need a DEFAULT_GENERATION constant ok. Will add to an earlier patch. Line 210: } Line 211: Line 212: def getInfo(self): Line 213: """ -- To view, visit https://gerrit.ovirt.org/64485 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62a6bb44c5f789acf3c63953f4b87c72585becc1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
