Adam Litke has posted comments on this change. Change subject: storage: Report generation id in volume.getInfo ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/64485/2/tests/storage_volume_test.py File tests/storage_volume_test.py: Line 138: vol = env.sd_manifest.produceVolume(img_id, vol_id) Line 139: vol.getLeaseStatus = lambda: 'unused' Line 140: vol.setMetaParam(sc.GENERATION, generation) Line 141: self.assertEqual(generation, vol.getInfo()['generation']) Line 142: > Do we need a test for volume without generation? I'll permutate this test so we can check that case explicitly. Line 143: Line 144: class CountedInstanceMethod(object): Line 145: def __init__(self, method): Line 146: self._method = method https://gerrit.ovirt.org/#/c/64485/2/vdsm/storage/volume.py File vdsm/storage/volume.py: Line 215 Line 216 Line 217 Line 218 Line 219 > This always uses VolumeMetadata, right? correct. -- To view, visit https://gerrit.ovirt.org/64485 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62a6bb44c5f789acf3c63953f4b87c72585becc1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
