Nir Soffer has posted comments on this change.

Change subject: storage: Report generation id in volume.getInfo
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64485/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

Line 6964:             type: *VolumeLeaseStatus
Line 6965: 
Line 6966:         -   description: A monotonically increasing generation id
Line 6967:             name: generation
Line 6968:             type: uint
> these are keywords in the schema.  I don't think we have anything more spec
We want to use signed value to make it easier for Java (no unsigned integers). 
If we don't have anything else we can use long - already used in some verb.
Line 6969:         type: object
Line 6970: 
Line 6971:     VolumeSizeInfo: &VolumeSizeInfo
Line 6972:         added: '3.1'


-- 
To view, visit https://gerrit.ovirt.org/64485
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62a6bb44c5f789acf3c63953f4b87c72585becc1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to