Ido Barkan has posted comments on this change. Change subject: refactor StaticSourceRoute for better testability ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/34067/5/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 344: IP_MASK, IP_GATEWAY))._table Line 345: Line 346: def getTestNetworkIpAddress(self): Line 347: vdsm_net = self.vdsm_net.netinfo.networks[NETWORK_NAME] Line 348: ip_addr = str(netaddr.IPAddress(vdsm_net['addr'])) > Could you explain how str(netaddr.IPAddress(vdsm_net['addr'])) is different it does not. probably a refactoring residue. reomving. Line 349: return ip_addr Line 350: Line 351: def assertSourceRoutingConfiguration(self, deviceName, ip_addr): Line 352: """assert that the IP rules and the routing tables pointed by them -- To view, visit http://gerrit.ovirt.org/34067 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If81c71b83670ee0c721dcce449e48ccc21e3bbec Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
