Dan Kenigsberg has submitted this change and it was merged. Change subject: refactor StaticSourceRoute for better testability ......................................................................
refactor StaticSourceRoute for better testability changed the way this object is built such that most of the relevant information is known at object creation time. This allows better testability as the routing rules and ip rules generators can be always accessed directly by tests. Change-Id: If81c71b83670ee0c721dcce449e48ccc21e3bbec Signed-off-by: ibarkan <[email protected]> Reviewed-on: http://gerrit.ovirt.org/34067 Reviewed-by: Dan Kenigsberg <[email protected]> --- M tests/functional/networkTests.py M vdsm/network/configurators/__init__.py M vdsm/network/sourceroute.py M vdsm/network/sourceroutethread.py 4 files changed, 71 insertions(+), 123 deletions(-) Approvals: Ido Barkan: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34067 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If81c71b83670ee0c721dcce449e48ccc21e3bbec Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
