Ido Barkan has posted comments on this change. Change subject: refactor StaticSourceRoute for better testability ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/34067/5/vdsm/network/sourceroute.py File vdsm/network/sourceroute.py: Line 52: network = netaddr.IPNetwork('%s/%s' % (ipaddr, mask)) Line 53: return "%s/%s" % (network.network, network.prefixlen) Line 54: Line 55: def _generateTableId(self, ipaddr): Line 56: # TODO: Future proof for IPv6 > Just a note: Intuitively a function called generateTableId returns an int. Done Line 57: return str(netaddr.IPAddress(ipaddr).value) Line 58: Line 59: def _buildRoutes(self): Line 60: return [Route(network='0.0.0.0/0', via=self._gateway, -- To view, visit http://gerrit.ovirt.org/34067 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If81c71b83670ee0c721dcce449e48ccc21e3bbec Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
