Nir Soffer has posted comments on this change. Change subject: hba: Rescan using SCSI layer ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/34245/5/vdsm/storage/fc-scan File vdsm/storage/fc-scan: Line 63: def run(self): Line 64: try: Line 65: path = "/sys/class/scsi_host/%s/scan" % self.host Line 66: log.debug("Scanning %s", path) Line 67: start = time.time() > I'd slightly prefer os.times()[4] despite of its lower resolution, but anyw Ok, will use os.times. The purpose of this is to make it easy to debug when scanning is slow (which I could not reproduce yet), and in this situation we don't care about higher resolution. Line 68: fd = os.open(path, os.O_WRONLY) Line 69: try: Line 70: os.write(fd, "- - -") Line 71: finally: -- To view, visit http://gerrit.ovirt.org/34245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7deb3047f1b75c4c65d59602b908835515290993 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
