Dan Kenigsberg has posted comments on this change. Change subject: hba: Rescan using SCSI layer ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/34245/5/lib/vdsm/constants.py.in File lib/vdsm/constants.py.in: Line 163: Line 164: EXT_VDSM_TOOL = os.path.join('@BINDIR@', 'vdsm-tool') Line 165: Line 166: EXT_CURL_IMG_WRAP = '@LIBEXECDIR@/curl-img-wrap' Line 167: EXT_FC_SCAN = '@LIBEXECDIR@/fc-scan' > I checked this, using explicit path or CommandPath is wrong. this constants.py junkyard is horrid, but adding yet another bit to it would not end the universe. -- To view, visit http://gerrit.ovirt.org/34245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7deb3047f1b75c4c65d59602b908835515290993 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
