Nir Soffer has posted comments on this change. Change subject: hba: Rescan using SCSI layer ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/34245/6/vdsm/storage/fc-scan File vdsm/storage/fc-scan: Line 86: level=logging.DEBUG if '-v' in args else logging.INFO, Line 87: format="%(name)s: %(message)s") Line 88: Line 89: hosts = [os.path.basename(path) Line 90: for path in glob.glob("/sys/class/fc_host/host*")] > As far as I know the D state will last for as much as the scsi timeout (or In my tests, scanning fc_hosts never takes more then few milliseconds. We tried to disconnect the fiber, block the host in the storage server and unmap luns in use by the host. Lets delay the fancy accounting system until we have a real problem. Line 91: Line 92: if not hosts: Line 93: log.debug("No fc_host found") Line 94: return 0 -- To view, visit http://gerrit.ovirt.org/34245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7deb3047f1b75c4c65d59602b908835515290993 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
