Dan Kenigsberg has posted comments on this change. Change subject: multipath configurator: reload only if service is active ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/36387/5/lib/vdsm/tool/configurators/multipath.py File lib/vdsm/tool/configurators/multipath.py: Line 144 Line 145 Line 146 Line 147 Line 148 > Assume this failed because the service was down. There is no point in checking the return value of service_reload() - if it fails, it raises an exception raise ServiceOperationError( "%s failed" % alt.func_name, out, err) -- To view, visit http://gerrit.ovirt.org/36387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1e8eceaaa486f05b1ea4f1733df669b2a44682a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
