Yeela Kaplan has posted comments on this change. Change subject: multipath configurator: reload only if service is active ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/36387/5/lib/vdsm/tool/configurators/multipath.py File lib/vdsm/tool/configurators/multipath.py: Line 144 Line 145 Line 146 Line 147 Line 148 > There is no point in checking the return value of service_reload() - if it There can be 2 cases in which exceptions when reloading a service are raised : multipath service is down - in that case configure succeeds. (and in this case we would like to avoid reloading altogether...) multipath service is up - in that case configure fails and we do want to raise an exception. -- To view, visit http://gerrit.ovirt.org/36387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1e8eceaaa486f05b1ea4f1733df669b2a44682a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
