Dear Jeremy!
On 16/10/12 13:16, Jeremy Sanders wrote:
>
> I had a quick look through the current commits and it looks good!
Just finished the refacturing of the code into the new folder structure.
I noticed that we are quite neighbors. You are located in Garching, MUC,
Germany, I am sitting in Schongau (Richard-Strauß-Str.1, 86956
Schongau, 08861 690 474 0) only 100 km away.
If you like to have a beer with me, just call me. My wife works for German
weather service and runs LIDAR and Ceilometer system on Observatory
Hoher Peißenberg, near Schongau.
Thomas is also quite often in MUC so we may have a sprint on veusz together, if
you like.
Some things that I noticed:
* Your code is very good! I have seldom come across a code (so old) that is
structured so plain and even after such a long time. Surely there
are traces of aging but they are not bad.
So the refactoring was boring. But that is better than cursing whole the time
while doing an EXCITING refactoring.
* The import of python modules at some places is quite nested. So much nested
that my eclipse cannot cope with! Especially the statements
import veusz.qtall as qt4
drive my eclspse mad.
It may be a good thing to refactor the import statements in a more uniform
fashion. From my perspective there is no need for
import XXX.YYY as ZZZ
if the naming convention of the modules is good. Since many of the modules
are touched in the current refactoring it may be no great deal to
refactor the imports quite well.
Had very nasty errors with the import order of modules in python recently,
so I am burned with any import that is not canonical aka
from xxx.yyy.zzz import <class>, or whatever
Maybe Thomas can elaborate on that subject. He has build systems far more
complex than Veusz. And has quite a wisdom of "Better not to do"s
in python.
* I have never worked with the FITS file format. I tried to import a sample
FITS-File from NASA but failed (not by stacktraces, but by not
knowing what to do). You are the astronomer, so please test if the migrated
FITS still fits :-)
* Just noticed that I have broken all your tests. I will start fixing them
right now. Sorry for the inconvenience. I will return after fixing
the tests, for you to check the code.
Since you are in Germany. Do you like to meet us on the PyCon [1] in Leipzig
20.10-3.11.
[1] https://2012.de.pycon.org/
Best regards
Volker
--
Dr. Volker Jaenisch
Geschäftsführer
Inqbus GmbH & Co. KG
Softwareentwicklung, Consulting & Hosting
Karl-Heine-Straße 99 | 04229 Leipzig | Deutschland
Telefon: +49 341 989758-54
Fax: +49 341 989758-79
E-Mail: [email protected]
Web: http://inqbus.de/
Persönlich haftende Gesellschafterin: Inqbus Management GmbH (Amtsgericht
Leipzig, HRB 27350)
Vertretungsberechtigte Geschäftsführer: Maik Derstappen, Dr. Volker Jaenisch,
Thomas Massmann, Markus Zapke-Gründemann
Registergericht: Amtsgericht Leipzig
Registernummer: HRA 16424
Umsatzsteuer-Identifikationsnummer: DE278744671
_______________________________________________
Veusz-discuss mailing list
[email protected]
https://mail.gna.org/listinfo/veusz-discuss
