----- Original Message ----- | From: "Gary Jennejohn" <ga...@gmx.de> | To: "Vile mailing list" <vile@nongnu.org> | Sent: Monday, January 2, 2023 3:02:03 PM | Subject: Re: Start again with syntax highlighting problem
| On Mon, 2 Jan 2023 14:17:43 -0500 | Thomas Dickey <dic...@his.com> wrote: | |> On Mon, Jan 02, 2023 at 10:45:14AM +0000, Chris Green wrote: |> > OK, restart, I think I now see a pattern in this. I completely |> > removed and re-installed vile from the Ubuntu repositories on esprimo |> > and it is now working correctly there. I had modified it there |> > because of the issue a while ago with UTF8 characters. So the table |> > is now as follows:- |> > |> > backup xubuntu 22.10 vile 9.8w colour OK, but not right |> > bison Android 11 vile 9.8w colour OK, but not right |> > caracal Debian 10 vile 9.8 no colour syntax |> > cheddar Debian 10 vile 9.8t colour OK |> > esprimo xubuntu 22.04 vile 9.8v colour OK |> > isbd Ubuntu 20.04 vile 9.8t colour OK |> > odin Debian 9 vile 9.8s colour OK |> > pimedia Debian 11 vile 9.8u colour OK |> > t470 xubuntu 22.10 vile 9.8w colour OK, but not right |> > tsohost very old vile 9.8 no colour syntax |> > |> > |> > This makes *much* more sense! :-) The systems with versions older |> > than vile9.8w do syntax highlighting OK. The two systems where I |> > built vile myself and installed as a user (no root access) don't do |> > syntax highlighting but thati's almost certainly something I have |> > missed out in the build and it's not so important there anyway. |> > |> > So, the question is why the syntax highlighting of vilemode for |> > version 9.8w is messed up. It's not badly wrong, it gets the colour |> |> I made an incorrect bug-fix in 9.8w for vilemode, which is fixed in 9.8x |> |> This was the change (reverting it will fix the bug): |> |> @@ -17,7 +17,7 @@ |> |> #define FLTSTACK_EXTRA int with_state; int with_active; |> #define FltStack_WITH_STATE FLTSTACK_THIS.with_state |> -#define FltStack_WITH_ACTIVE FLTSTACK_THIS.with_state |> +#define FltStack_WITH_ACTIVE FLTSTACK_THIS.with_active |> #include <fltstack.h> |> |> #if defined(_estruct_h) && !SMALLER |> | | This is peculiar. In my 9.8w code (FreeBSD) this error is not present. The tarballs and patches should match the snapshots that I export to Git: https://github.com/ThomasDickey/vile-snapshots/commit/49e69b2a9c24709e8dc6534842c531f036fc6ef5#diff-2f62c16021dc47a5af4606a274a77fe2684bb704641a215e2c7147e8e7d8c362 |> > of comments right throughout but gets confused about keyword colours |> > and within some 'map' settings. As far as I can see on other file |> > types (shell scripts, python, C) version 9.8w gets the highlighting |> > correct so it does look like just an error in the vilemode |> > highlighting. |> > |> > Has the vile-filt-filt file changed between 9.8v and 9.8w? -- Thomas E. Dickey <dic...@invisible-island.net> https://invisible-island.net
