Hi George V. Reilly, you wrote:

> * Win64 changes to make code compile cleanly: eval.c, misc2.c, if_ole.*
> ...

I've checked the patch - works fine for me as well. A couple of other notes:

* It seems stuff like

#>>>>> path of the compiler and linker; name of include and lib directories
# PATH = c:\msvc20\bin;$(PATH)
# INCLUDE = c:\msvc20\include
# LIB = c:\msvc20\lib
     
should be cleaned out as well.

* In statements

CFLAGS = $(CFLAGS) /MD
LIBC = msvcrt.lib

and other 3 variants of this, setting LIBC is redundant. The /MXx options 
already add information about the library to be linked in into object files. I 
still think that /nodefaultlib should be removed completely. This option is 
really dangerous and 99% of cases when you have a warning from linker like

LINK : warning LNK4098: defaultlib "LIBCMT" conflicts with use of other libs; 
use /NODEFAULTLIB:library 

you're going to have problems due to runtime conflicts.

* BTW, I've got a nuclear mix of VS + Platform SDK on my home machine which 
gives the following warning during the compilation:

c:\program files\microsoft sdk\include\winnt.h(768) : warning C4163: '_rotl64' 
: not available as an intrinsic function

I get a lot of them. It's not about this particular patch, though - just a 
complain. :-)

-- 
Alexei Alexandrov

Reply via email to