Jonathan Smith wrote:

> I know this is sortof late notice, but it would be great if this could
> go in 7.1 final :)
> 
> > The empty comment is still there.  Just leave that line blank.  No
> > biggie, of course, just aesthetics.
> 
> i could have sworn i fixed it. this time, though, it really is fixed. :)
> 
> >> runtime! syntax/python.vim
> >
> > Just to make sure: Python is allowed anywhere in a conary recipe?
> 
> correct. a recipe is a special type of python file
> 
> >> syn match   conaryMacro         "%(\w*)[sd]" contained
> >> syn match   conaryBadMacro      "%(\w*)[^sd]" contained " no final marker
> >
> > OK, so you can have the following:
> >
> > %()s
> >
> > or should it be "%(\w\+)[sd]"
> 
> you're right. fixed
> 
> >>   HiLink conaryUseFlag          Typedef
> >
> > Substitute that with
> > hi def link conaryrecipeMacro Macro
> > :
> > :
> 
> fixed
> 
> > (If conary recipe macros aren't much like macros in C, then perhaps
> > Special is better.  Also note the linking of a generic group to
> > function and then other groups linking to them so that a user can
> > change them all en masse, to something they like.)
> 
> fixed
> 
> > That HiLink cruft is also Vim5 compatibility stuff.  And remove the if
> > statement.
> 
> fixed
> 
> >> let b:current_syntax = "recipe"
> >
> > This should be
> >
> > let b:current_syntax = "conaryrecipe"
> 
> fixed

The only thing that I now spot is that the syntax items start with
"conary" instead of "conaryrecipe".  That's a tiny issue though, since
if there is another conaryXXX syntax you can make sure there are no
conflicts.

I'll include the syntax file now.

-- 
hundred-and-one symptoms of being an internet addict:
80. At parties, you introduce your spouse as your "service provider."

 /// Bram Moolenaar -- [EMAIL PROTECTED] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\        download, build and distribute -- http://www.A-A-P.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Reply via email to