On May 5, 11:14 am, Bram Moolenaar <[email protected]> wrote:
> Pankaj Garg wrote:
> > On May 4, 10:50 pm, Dominique Pellé <[email protected]> wrote:
> > > _Lone wrote:
> > > > On May 2, 11:32 pm, Dominique Pellé <[email protected]> wrote:
> > > >> _Lone wrote:
> > > >> >> I have modified the patch. The name is nowmargincolumn. The
> > > >> >> behavior is:
> > > >> >> 'mc' = 0 -> off
> > > >> >> 'mc' > 0 -> highlightes the column.
> > > >> >> 'mc' < 0 -> makes 'mc' = 'tw + 1' and highlightes that column.
>
> > > >> >> I also updated the related documentation is option.txt.
>
> > > >> >> Thanks
> > > >> >> _Lone
>
> > > >> I've tested your updated patch with Vim-7.2.166 on Linux x86.
> > > >> So far it works as it should. No problem to report.
>
> > > >> I also think that the idea mentioned earlier in this thread to
> > > >> support multiple margincolumns is a good one.
>
> > > >> For example:set mc=40,80
>
> > > >> It can be handy when editing files with multiple columns.
>
> > > >> Thanks
> > > >> -- Dominique
>
> > > > Hi Dominique,
>
> > > > Could you please try cursor column without the patch and see what that
> > > > does? I implemented themargincolumnto behave similar to cursorcolumn
> > > > so I think they both would behave the same. But still it would be good
> > > > to check withoutmargincolumnpatch to make sure there is no
> > > > regression.
>
> > > > I am not sure how to handle multi-byte characters. My experience is
> > > > limited with that. Anyone has any suggestions?
>
> > > > Thanks
> > > > _Lone
>
> > > Confirmed: Pristine Vim-7.2.166 has the same odd behavior
> > > when doing ":set cuc" with characters using 2 display cells
> > > (utf-8 on Linux with xterm as well as with gvim (GTK2).
>
> > > So this behavior is not introduced by themargincolumnpatch.
>
> > > See this screenshot with gvim-7.2.166 GTK2:
>
> > >http://dominique.pelle.free.fr/pic/gvim-cuc.png
>
> > > cursorcolumn is supposed to be highlighted in grey.
> > > The cuc is not highlighted in some lines. The red square
> > > at the top is the location of the cursor.
>
> > > -- Dominique- Hide quoted text -
>
> > > - Show quoted text -
>
> > Thanks for the confirmation that this is not a regression. I feel that
> > multi-column character bug needs to be fixed separately and it would
> > be a little tricky to fix this because of the way 'cursorcolumn'
> > highlighting works.
>
> > Bram - Does the 'margincolumn' patch fits the need? If there is any
> > other feedback please let me know?
>
> > The following are the two things that probably needs to be considered
> > in future:
> > 1. Highlighting of multi-column characters for both CUC and MC.
> > 2. Support for margin-column to contain multiple values to highlight
> > various columns.
>
> I don't have time to look into this soon, thus use comments from others.
> This is a new feature and needs a bit of trying out anyway.
>
> The wide character problem is a separate one. But if you can solve it
> for 'cuc' as well that would be nice.
>
> --
> ROBIN: The what?
> ARTHUR: The Holy Hand Grenade of Antioch. 'Tis one of the sacred relics
> Brother Maynard always carries with him.
> ALL: Yes. Of course.
> ARTHUR: (shouting) Bring up the Holy Hand Grenade!
> "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
>
> /// Bram Moolenaar -- [email protected] --http://www.Moolenaar.net \\\
> /// sponsor Vim, vote for features --http://www.Vim.org/sponsor/\\\
> \\\ download, build and distribute --http://www.A-A-P.org ///
> \\\ help me help AIDS victims --http://ICCF-Holland.org ///-
> Hide quoted text -
>
> - Show quoted text -
I got a little busy with my day-job so couldn't look at it but I have
some time this week.
I looked at adding 1px highlighting instead of whole character
background. But it seems it would be very difficult. The reason is
that the way highlighting works is by storing the background color for
character which is how various highlights are done.
I also looked at wide-character problem and that too looks very hard
to sovle though I would spend some more time this week if I can fix
that.
Thanks
_Lone
--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---
