On 16-Apr-2010 Christian Brabandt <[email protected]> wrote: > Hi James! > > On Fr, 16 Apr 2010, James Vega wrote: > > > On Fri, Apr 16, 2010 at 11:28 AM, Marvin Renich <[email protected]> wrote: > > > * Christian Brabandt <[email protected]> [100416 08:35]: > > >> This has come up on the vim_use mailinglist. The problem seems to be > > >> that after recovery of a swap buffer, the file should be modified so you > > >> are not loosing your changes after e.g. accidently hitting ZZ > > >> > > > Shouldn't this set curbuf->b_changed based on the "modified" setting > > > from the swap file, so that if you "recover" a file that was not > > > modified, you don't set the modified flag? > > > > I'd think that any time you recover from a swap file, the buffer should > > be considered "modified". The modified flag indicates that the buffer > > is different than the on-disk file with the same name. Whether or not > > the buffer was modified at the time that the swap file was last updated > > has no bearing on whether the content recovered from the swap file > > matches the current contents of the file that was being edited. That's > > up to the user to diagnose and decide what steps to take. > > That would be my understanding as well.
Correct me if I am wrong, but I understand that the current behaviour is that if you recover a file it does not get the "modified" attribute. As a result if you press ZZ, you exit Vim without saving the recovered contents. While this might seem like a defect, I find it to prevent me from accidentally overwriting the contents of the original file on the disk. And I can always restore the contents that have not been written when I pressed ZZ by invoking Vim once again with "-r swapfile-name" arguments. IOW, I personally prefer the current behaviour. Still, I believe that there might be a somewhat more complicated solution which would satisfy both needs. But then, maybe Bram decides it's a bug in fact? -- Cheers, Lech -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php Subscription settings: http://groups.google.com/group/vim_dev/subscribe?hl=en
