Christian, thanks for tackling a ton of little nitpicks I've had with Vim! One thing in general that would be awesome if fixed, especially in line with this patch, would be that when scrolling past lines that are wrapped, not having the document jump the number of lines the wrap take up. It makes for a very jarring experiencing when scrolling past these wrapped lines.
I don't know any C really, so I don't think I would have the ability to assist, so just mentioning it as a nice to have. On Thursday, June 26, 2014 2:08:27 PM UTC-7, Bram Moolenaar wrote: > Christian wrote: > > > > > On Mi, 25 Jun 2014, Bram Moolenaar wrote: > > > > > > > Bram wrote: > > > > > > > > > Christian wrote: > > > > > > > > > > > Finally a new patch, here we go: > > > > > > > > [...] > > > > > > > > > Thanks, much better now. > > > > > > > > > > Let me include it and make a few small improvements. I'm sure we will > > > > > discover more problems once more people use the feature, I hope you will > > > > > fix these problems then! > > > > > > > > I already found and fixed a few problems. > > > > > > > > When starting Vim the default values for the 'briopt' option are not > > > > used. > > > > > > > > The documentation says that the default for the minimum is 20, but the > > > > implementation uses a default of 0. A default of 20 is much more > > > > useful, so let's use that. I had to change the tests to compensate. > > > > Now we might as well make the default value empty. > > > > > > > > I added TODO items in places where I did not understand the code, mainly > > > > failing to pass in the start of the line, thus computing indent on > > > > somewhere halfway a line. If the pointer doesn't matter we better pass > > > > NULL, so it's clear we do not compute the indent. If it does matter I > > > > suspect there are situations where the column is not computed correctly. > > > > > > > > Please have a look at these added TODO items. > > > > > > Attach patch fixes a few problems: > > > > > > 1) I think you are correct with the few TODO items. I have changed that > > > to the correct line pointer. > > > 2) small fix for the test (the strdisplay() was executed in the wrong > > > window, hence the difference) > > > 3) Changed default_value of briopt back to 'shift:0,min:20'. If you > > > don't like that, feel free to skip that part. > > > 4) do not cache the indent, as it seems to cause more problems, then it > > > solves (see recent bug report here). > > > > Thanks for the quick response! > > > > Are there still remaining problems for the cached indent? > > > > -- > > There are 2 kinds of people in my world: those who know Unix, Perl, Vim, GNU, > > Linux, etc, and those who know COBOL. It gets very difficult for me at > > parties, not knowing which group to socialise with :-) > > Sitaram Chamarty > > > > /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ > > /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ > > \\\ an exciting new programming language -- http://www.Zimbu.org /// > > \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
