Christian wrote:
> Finally a new patch, here we go:
>
> On Do, 29 Mai 2014, Bram Moolenaar wrote:
> > Christian wrote:
> > > On Mi, 28 Mai 2014, Bram Moolenaar wrote:
> > > > A few remarks from looking at the patch.
> > > >
> > > > There aren't any tests, while there are lots of changes to the source
> > > > code. It would be really useful to have tests, instead of hoping that
> > > > later changes won't break the feature.
>
> I added tests.
>
> > > > The line number argument is added to lbr_chartabsize(). Instead it
> > > > should pass a pointer to the start of the line. Fetching the line again
> > > > may cause trouble. I also wonder if recomputing the indent every time
> > > > can't be avoided. As far as I can see the result of the computation is
> > > > the same every time. Perhaps the value can be cached for as long as
> > > > working on the same line.
>
> Instead of the line number, lbr_chartabsize() functions now take an
> additional char_u *ptr and the indent is cached to avoid unneccessary
> calls to get_indent_str() function.
>
> > > > The lnum argument to strdisplaywidth() doesn't work if the text is not
> > > > in the current window. Instead the text for the indent should be
> > > > passed.
> > >
> > > okay, will look into it.
>
> Not necessary any more. strdisplaywidth() can be left unchanged.
>
> > > > The result of parsing breakindentopts should not be put in w_p_* fields.
> > > > These names are used for actual options, not parsed values. Looks like
> > > > a leftover from when this was a bunch of options instead of one option
> > > > with several items.
>
> Done that.
>
> > > > The FIXME items need to be fixed...
>
> Those are removed as they are not valid anymore.
Thanks, much better now.
Let me include it and make a few small improvements. I'm sure we will
discover more problems once more people use the feature, I hope you will
fix these problems then!
--
GUARD #2: It could be carried by an African swallow!
GUARD #1: Oh, yeah, an African swallow maybe, but not a European swallow,
that's my point.
GUARD #2: Oh, yeah, I agree with that...
The Quest for the Holy Grail (Monty Python)
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
