Christian -
> On Mi, 25 Jun 2014, Bram Moolenaar wrote:
>
> > > Christian wrote:
> > >
> > > > Finally a new patch, here we go:
> >
> > [...]
> >
> > > Thanks, much better now.
> > >
> > > Let me include it and make a few small improvements. I'm sure we will
> > > discover more problems once more people use the feature, I hope you will
> > > fix these problems then!
> >
> > I already found and fixed a few problems.
> >
> > When starting Vim the default values for the 'briopt' option are not
> > used.
> >
> > The documentation says that the default for the minimum is 20, but the
> > implementation uses a default of 0. A default of 20 is much more
> > useful, so let's use that. I had to change the tests to compensate.
> > Now we might as well make the default value empty.
>
> Huh? The default for briopt was 'shift:0,min:20' which should actually
> use 20. Using an empty value for briopt will make Vim always use 20, if
> min is not set, even if explicitly making briopt empty. That is at least
> unexpected. I think, this also causes the needed change to the ok file
> (infact, the idea was, that the computed length and the length of
> strdisplaywidth should be the same).
An emtpy option means to use the default "sane" values. That's
especially convenient when adding more items. Also compare with
'cinoptions', which has a huge number of items, but the default is
empty.
> > I added TODO items in places where I did not understand the code, mainly
> > failing to pass in the start of the line, thus computing indent on
> > somewhere halfway a line. If the pointer doesn't matter we better pass
> > NULL, so it's clear we do not compute the indent. If it does matter I
> > suspect there are situations where the column is not computed correctly.
> >
> > Please have a look at these added TODO items.
>
> I will. You are probably right about those TODO items. I need to check
> that first, however.
Good luck. And if you indeed find a problem, you discovered something
to add to the tests :-).
--
WOMAN: I didn't know we had a king. I thought we were an autonomous
collective.
DENNIS: You're fooling yourself. We're living in a dictatorship. A
self-perpetuating autocracy in which the working classes--
WOMAN: Oh there you go, bringing class into it again.
DENNIS: That's what it's all about if only people would--
The Quest for the Holy Grail (Monty Python)
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
