On 31 July 2014 18:32, Andre Sihera <[email protected]> wrote: > The proposed patch may fix glyph replacement but have you broken > right-to-left display using Hebrew and Arabic fonts? I haven't checked > the code but it appears gViM may do its own RTL processing which > is why this flag was specified. > > You should check this as well before declaring your patch "safe".
I did check that setting RTL worked as I expected, but I'm definitely not an expert in this. If someone can tell me exactly what needs testing, I'll happily check. The comments in the code say that the flag only exists under Windows NT and later, and there's fallback code for Windows 95 that does the job "manually", but is slower. Essentially what I've done by removing the flag is to make Vim think it should use the Windows 95 (do it yourself) code always - so I don't think it's possible for my change to have introduced any bug that wasn't already in the code (for Windows 95, at least). The comments imply that by not using the flag, the redraw code could be slower. That's possible - all I can say is that I didn't notice any perceptible slowdown, and modern hardware is so much faster than what was around when the code was written that I'd be surprised if it were a practical issue. Paul -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
