Hello vim-dev!
My name is Ian Halliday, this is my first time sending mail to
[email protected]. Please be kind to me :)
I humbly would like to submit a patch to vim to remove the WS_EX_CLIENTEDGE
client frame border so that gVim looks super sexy smooth in Windows 10 (and
much less antiquated in Windows Vista/7/8/8.1).
Attached is the simple patch. I have tested this briefly on Windows 7,
8.1, and 10 and found no glaring issues. This patch also seems to fix a
strange dead-space margin issue on Windows 10.
To see screenshots of what this looks like please take a look at this imgur
album: http://imgur.com/a/lbzEA
I considered versioning this or otherwise controlling it by trying to check
to see if a classic theme was applied but I decided doing so was more
complicated than it was worth. Particularly since even with a classic
theme this gVim does not look bad at all with this change (see imgur Win7
with classic theme screenshot).
Since Windows XP is no longer supported and Microsoft will be pushing for
everyone to upgrade to Windows 10 later this year I figure it is not worth
the trouble of trying to allow users to go back to the old WS_EX_CLIENTEDGE
look.
This is my take though. I am brand new to the vim dev community and
certainly would like to hear other opinions and feedback.
Let me know what y'all think.
Cheers!
Ian Halliday
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
diff -r ca3db36a6ed8 src/gui_w32.c
--- a/src/gui_w32.c Thu May 14 05:56:09 2015 +0200
+++ b/src/gui_w32.c Fri May 15 16:38:56 2015 -0700
@@ -1661,7 +1661,7 @@
return FAIL;
}
s_textArea = CreateWindowEx(
- WS_EX_CLIENTEDGE,
+ 0,
szTextAreaClass, "Vim text area",
WS_CHILD | WS_VISIBLE, 0, 0,
100, /* Any value will do for now */
@@ -1717,8 +1717,9 @@
/*
* Start out by adding the configured border width into the border offset
+ * 5/15/2015: Removed WS_EX_CLIENTEDGE so there is no longer a
border_offset
*/
- gui.border_offset = gui.border_width + 2; /*CLIENT EDGE*/
+ gui.border_offset = gui.border_width;
/*
* Set up for Intellimouse processing
