Oops, that's my fault (^_^;)

The compiler warning and the linker error are caused by the function
pango_attr_foreground_alpha_new(), which was newly added to Pango last
autumn (1.38, 2015-10-12).

Hence the same build failure happens if Pango in use is older than 1.38.

The attached patch fixes that issue by adding version checks against Pango.

Best,
Kazunobu Kuriyama

2016-07-22 5:56 GMT+09:00 Dominique Pellé <[email protected]>:

> Bram Moolenaar wrote:
>
> > Patch 7.4.2089
> > Problem:    Color handling of X11 GUIs is too complicated.
> > Solution:   Simplify the code.  Use RGBA where appropriate. (Kazunobu
> >             Kuriyama)
> > Files:      src/gui.h, src/gui_beval.c, src/gui_gtk_x11.c, src/netbeans.c
>
>
> Vim with gtk3 gui no longer builds successfully with patch 7.4.2089
> on my xubuntu-14.04.4 laptop:
>
> $ ./configure --with-features=huge --enable-gui=gtk3
> ...snip...
> $ make
> ...snip...
> $ gui_beval.c: In function ‘set_printable_label_text’:
> gui_beval.c:1118:15: warning: assignment makes pointer from integer
> without a cast
>     attr_alpha = pango_attr_foreground_alpha_new(
>                ^
> ....snip...
>   gcc   -L/usr/local/lib -Wl,--as-needed     -o vim objects/arabic.o
> objects/buffer.o objects/blowfish.o objects/charset.o objects/crypt.o
> objects/crypt_zip.o objects/dict.o objects/diff.o objects/digraph.o
> objects/edit.o objects/eval.o objects/evalfunc.o objects/ex_cmds.o
> objects/ex_cmds2.o objects/ex_docmd.o objects/ex_eval.o
> objects/ex_getln.o objects/farsi.o objects/fileio.o objects/fold.o
> objects/getchar.o objects/hardcopy.o objects/hashtab.o
> objects/if_cscope.o objects/if_xcmdsrv.o objects/list.o objects/mark.o
> objects/memline.o objects/menu.o objects/misc1.o objects/misc2.o
> objects/move.o objects/mbyte.o objects/normal.o objects/ops.o
> objects/option.o objects/os_unix.o objects/pathdef.o
> objects/popupmnu.o objects/quickfix.o objects/regexp.o
> objects/screen.o objects/search.o objects/sha256.o objects/spell.o
> objects/spellfile.o objects/syntax.o objects/tag.o objects/term.o
> objects/ui.o objects/undo.o objects/userfunc.o objects/version.o
> objects/window.o objects/gui.o objects/gui_gtk.o objects/gui_gtk_x11.o
> objects/pty.o objects/gui_gtk_f.o objects/gui_beval.o
> objects/netbeans.o objects/channel.o  objects/json.o objects/main.o
> objects/memfile.o objects/message.o   -lgtk-3 -lgdk-3 -latk-1.0
> -lgio-2.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lcairo-gobject
> -lpango-1.0 -lcairo -lgobject-2.0 -lglib-2.0   -lSM -lICE -lXpm -lXt
> -lX11 -lXdmcp -lSM -lICE  -lm -ltinfo -lnsl  -lselinux -lacl -lattr
> -lgpm -ldl
> objects/gui_beval.o: In function `set_printable_label_text':
> /home/pel/sb/vim/src/gui_beval.c:1118: undefined reference to
> `pango_attr_foreground_alpha_new'
> collect2: error: ld returned 1 exit status
> link.sh: Linking failed
>
> Regards
> Dominique
>
> --
> --
> You received this message from the "vim_dev" maillist.
> Do not top-post! Type your reply below the text you are replying to.
> For more information, visit http://www.vim.org/maillist.php
>
> ---
> You received this message because you are subscribed to the Google Groups
> "vim_dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> For more options, visit https://groups.google.com/d/optout.
>

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Attachment: fix_pango_attr_alpha.patch
Description: Binary data

Raspunde prin e-mail lui