On Do, 25 Okt 2018, Bram Moolenaar wrote:
>
> I wrote:
>
> > Patch 8.1.0496
> > Problem: No tests for indent files.
> > Solution: Add a mechanism for running indent file tests. Add a first test
> > for Vim indenting.
> > Files: runtime/indent/Makefile, runtime/indent/testdir/runtest.vim,
> > runtime/indent/testdir/cleantest.vim, runtime/indent/README.txt,
> > runtime/indent/testdir/README.txt,
> > runtime/indent/testdir/vim.in,
> > runtime/indent/testdir/vim.ok, Filelist
>
> This patch makes it possible to write tests for indent files. I
> included a short example for Vim indenting. If you maintain an indent
> file, please check it out. Let me know if you would like to improve
> this somehow.
>
> I would expect some indent file maintainers to already have their own
> tests, that doesn't really change. Adding the tests to the distribution
> makes it easier for others to suggest improvements to the indent script,
> and run the tests to check there are no regressions.
>
> Adding the tests in the runtime directory makes it easier to keep them
> in sync with the indent scripts. Putting them under src/testdir would
> make that more difficult. And end users probably don't have
> src/testdir.
>
> It does make the runtime directory a bit bigger, but I don't think it is
> much and it's worth it.
I remembered that there was a patch adding tests for the indent
functions. However I searched for them in the src/testdir and did not
find them. So I find that a bit unfortunate to have 2 different testdir
directories in different places.
So I would suggest, at least adding a short section to
src/testdir/README.txt and mention where to put indent tests.
However, I think the indent tests should also be run as part of our test
suite, to catch problems early.
I am currently changed the xml indent scripts a bit, so once I am
satisfied will submit a new indent test together with the updated
runtime files.
Mit freundlichen Grüßen
Christian
--
Glaub an das Glück, denn sonst flieht es davon.
-- Alexandra
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
