Christian wrote:
> On Do, 25 Okt 2018, Bram Moolenaar wrote:
>
> > I wrote:
> >
> > > Patch 8.1.0496
> > > Problem: No tests for indent files.
> > > Solution: Add a mechanism for running indent file tests. Add a first
> > > test
> > > for Vim indenting.
> > > Files: runtime/indent/Makefile, runtime/indent/testdir/runtest.vim,
> > > runtime/indent/testdir/cleantest.vim,
> > > runtime/indent/README.txt,
> > > runtime/indent/testdir/README.txt,
> > > runtime/indent/testdir/vim.in,
> > > runtime/indent/testdir/vim.ok, Filelist
> >
> > This patch makes it possible to write tests for indent files. I
> > included a short example for Vim indenting. If you maintain an indent
> > file, please check it out. Let me know if you would like to improve
> > this somehow.
> >
> > I would expect some indent file maintainers to already have their own
> > tests, that doesn't really change. Adding the tests to the distribution
> > makes it easier for others to suggest improvements to the indent script,
> > and run the tests to check there are no regressions.
> >
> > Adding the tests in the runtime directory makes it easier to keep them
> > in sync with the indent scripts. Putting them under src/testdir would
> > make that more difficult. And end users probably don't have
> > src/testdir.
> >
> > It does make the runtime directory a bit bigger, but I don't think it is
> > much and it's worth it.
>
> I remembered that there was a patch adding tests for the indent
> functions. However I searched for them in the src/testdir and did not
> find them. So I find that a bit unfortunate to have 2 different testdir
> directories in different places.
This is because the src/testdir files are to be kept in sync with the
source code, thus need to be part of the patch with the relevant source
code change. While the indent tests need to go out with the runtime
file updates.
> So I would suggest, at least adding a short section to
> src/testdir/README.txt and mention where to put indent tests.
I'll do that.
> However, I think the indent tests should also be run as part of our test
> suite, to catch problems early.
Well, they are really separate test suites. The indent tests are run as
part of the checks I run before sending out runtime file updates.
Perhaps the toplevel Makefile could run both.
> I am currently changed the xml indent scripts a bit, so once I am
> satisfied will submit a new indent test together with the updated
> runtime files.
Great.
--
BEDEVERE: How do you know so much about swallows?
ARTHUR: Well you have to know these things when you're a king, you know.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
