Hi, On Sun, Jun 9, 2019 at 8:23 AM Bram Moolenaar <[email protected]> wrote: > > > > Recently Neovim added some thing similar. But instead of showing sign > > text in the number column, a sign option `numhl` was added to change > > the highlight of the number column. Similar to a sign only using > > `linehl`, such a sign doesn't need the sign column. > > > > The patch is here https://github.com/neovim/neovim/pull/9113/files but > > is bit out of date due to the recent sign refactors. If this is > > interesting I could help porting it. > > Hmm, it sounds a bit like another thing. The "numhl" attribute is on > the sign, thus you can easily end up with some signs using it and some > not. That sounds like another feature. > > The idea here is to put ALL signs in the number column. Just one > setting, which works both when there is a number column and when not. > Just saves the space for the sign column (which often is mostly empty). > Thus it still works when toggling the line number off and on. >
I am attaching a preliminary patch that implements the above. As the win_line() function uses too many variables, the new get_sign_display_info() function needs too many arguments. I don't like functions taking too many arguments. I can move the input and output set of arguments into separate structures and pass them to this function. Any suggestions? Also, the current win_line() function is too long (around 2150 lines). - Yegappan -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CAAW7x7mKiicyxdPxn9vu%2BE5HrAEsK0i-Q01wHPBek2OBuX5xZw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
sign.diff
Description: Binary data
