Yegappan wrote:
> On Sun, Jun 9, 2019 at 8:23 AM Bram Moolenaar <[email protected]> > wrote: > > > > > > > Recently Neovim added some thing similar. But instead of showing sign > > > text in the number column, a sign option `numhl` was added to change > > > the highlight of the number column. Similar to a sign only using > > > `linehl`, such a sign doesn't need the sign column. > > > > > > The patch is here https://github.com/neovim/neovim/pull/9113/files but > > > is bit out of date due to the recent sign refactors. If this is > > > interesting I could help porting it. > > > > Hmm, it sounds a bit like another thing. The "numhl" attribute is on > > the sign, thus you can easily end up with some signs using it and some > > not. That sounds like another feature. > > > > The idea here is to put ALL signs in the number column. Just one > > setting, which works both when there is a number column and when not. > > Just saves the space for the sign column (which often is mostly empty). > > Thus it still works when toggling the line number off and on. > > > > I am attaching a preliminary patch that implements the above. > As the win_line() function uses too many variables, the new > get_sign_display_info() function needs too many arguments. > I don't like functions taking too many arguments. I can move the > input and output set of arguments into separate structures and > pass them to this function. Any suggestions? > > Also, the current win_line() function is too long (around 2150 lines). Thanks for looking into this. Yes, win_line() has grown into a complex beast. It's not going to be easy to split it up, since there is so much state involved. It could work to move things like c_extra, n_extra, etc. into a struct. But they should also be renamed to make their purpose clearer. That's going to be some work. -- hundred-and-one symptoms of being an internet addict: 209. Your house stinks because you haven't cleaned it in a week. /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906161449.x5GEngEV013174%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
