Yegappan wrote:
> On Sun, Jun 16, 2019 at 7:32 AM Yegappan Lakshmanan <[email protected]> > wrote: > > On Sun, Jun 9, 2019 at 8:23 AM Bram Moolenaar <[email protected]> > > wrote: > > > > > > > Recently Neovim added some thing similar. But instead of showing sign > > > > text in the number column, a sign option `numhl` was added to change > > > > the highlight of the number column. Similar to a sign only using > > > > `linehl`, such a sign doesn't need the sign column. > > > > > > > > The patch is here https://github.com/neovim/neovim/pull/9113/files but > > > > is bit out of date due to the recent sign refactors. If this is > > > > interesting I could help porting it. > > > > > > Hmm, it sounds a bit like another thing. The "numhl" attribute is on > > > the sign, thus you can easily end up with some signs using it and some > > > not. That sounds like another feature. > > > > > > The idea here is to put ALL signs in the number column. Just one > > > setting, which works both when there is a number column and when not. > > > Just saves the space for the sign column (which often is mostly empty). > > > Thus it still works when toggling the line number off and on. > > > > > > > I am attaching a preliminary patch that implements the above. > > > > With this patch, when the 'signcolumn' option is set to 'number', > the signs are displayed only when the 'number' column is displayed. > Otherwise, the placed signs are not displayed. > > Instead of this, if the 'number' column is not displayed, should we > show the sign column and display the signs there? If the 'number' > column is enabled later, then remove the sign column and display > the signs in the number column? Similarly, if the 'number' column > is disabled, enable the sign column and show the signs there? When 'signcolumn' is set to "number" and there is no number column, it should behave either like "auto" or "yes". Since "auto" is the default, it would be that. An alternative is to be able to specify a fallback: set signcolumn=number,yes set signcolumn=number,auto set signcolumn=number,no > Also, in the 'number' column, when displaying the sign for a line, > the corresponding line number will not be shown for that line. I think that is OK, so long as there aren't many signs you can see the line number just above or below. -- Your mouse has moved. Windows must be restarted for the change to take effect. Reboot now? /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201906161711.x5GHB9EN010924%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
