On 03/21/2013 04:39 AM, Yu Mingfei wrote:
On 03/21/2013 04:29 PM, Alex Jia wrote:
On 03/20/2013 11:33 PM, Chris Evich wrote:
On 03/20/2013 06:11 AM, Yu Mingfei wrote:
virsh_instance = virsh.VirshPersistent(**virsh_dargs)
IIRC, you can recycle this by calling virsh_instance.new_session()
here, but it's only very small nit-pick, what you have is fine. The
test looks good overall.
ToDo: IIRC, there's a way to reboot the host and have autotest resume
testing when it comes up. I'm almost 100% sure this doesn't work with
current virt-test code, but it would be nice to get it
As usual, we restart libvirtd service to emulate host reboot for this
kinds of testing, in addition, you had better to check whether
$network.xml exists under the
/etc/libvirt/$hypervisor/networks/autostart/.
Actually it's more complicated than that. There's the "saved" config.
under that /etc/libvirt dir, then there's the "active" config under
/var/lib/libvirt/network/. It's libvirt's responsibility to manage
any/all differences and symlinks.
This is why I _really_ don't like us mucking around with files in
either. I much prefer us to use the virsh.*dumpxml functions to obtain
the data. Then if the usage semantics or location of these directories
ever changes, our tests will continue to work.
--
Chris Evich, RHCA, RHCE, RHCDS, RHCSS
Quality Assurance Engineer
e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
