On 03/21/2013 01:28 AM, Yu Mingfei wrote:
On 03/20/2013 11:33 PM, Chris Evich wrote:
On 03/20/2013 06:11 AM, Yu Mingfei wrote:
virsh_instance = virsh.VirshPersistent(**virsh_dargs)
IIRC, you can recycle this by calling virsh_instance.new_session()
here, but it's only very small nit-pick, what you have is fine. The
test looks good overall.
Yes, good idea. I will replace it before committed.
If you like to, it really is a very small thing. I just point it out
for future reference. Practical difference between two ways is probably
insignificant.
ToDo: IIRC, there's a way to reboot the host and have autotest resume
testing when it comes up. I'm almost 100% sure this doesn't work with
current virt-test code, but it would be nice to get it working. This
would be an ideal test to play with the host-reboot functionality.
Since this is the central-reason why autostart exists, and at some
point we will need to test the guest-autostart feature :)
In fact, My first thought about net-autostart is:
1.With setting autostart, the network will be active after I reboot
libvirtd
2.With setting disable, the network will be inactive after libvirtd is
restarted.
(Even though the network is active.)
Then I found if network is active, no matter I set autostart or disable,
the network will still be running after I restart libvirtd. :D
So rebooting host may be a more suitable choice.
But currently I just destroy the default network before I run testcases,
then check it after restarting libvirtd.
Yeah, I am afraid of over "cooking" the behavior could lead to "burning"
the results. Garbage-in / Garbage-out kind of thing. It's probably
best we just reboot the host.
All we need is two tests, or two cartesian config. modes:
Test / Set one: Setup VM/Network/Whatever for autorestart. If verify
setup is good, PASS.
<reboot happens>
Test / Set two: Verify VM/Network/Whatever expectations match for after
reboot, PASS. Restore environment to pre-test.
My thinking is just having one test module, and using a "before_reboot =
yes" or "no" parameter to control "mode" of test, will be most easy.
--
Chris Evich, RHCA, RHCE, RHCDS, RHCSS
Quality Assurance Engineer
e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
