On 03/21/2013 04:29 AM, Alex Jia wrote:
On 03/20/2013 11:33 PM, Chris Evich wrote:
On 03/20/2013 06:11 AM, Yu Mingfei wrote:
virsh_instance = virsh.VirshPersistent(**virsh_dargs)
IIRC, you can recycle this by calling virsh_instance.new_session()
here, but it's only very small nit-pick, what you have is fine. The
test looks good overall.
ToDo: IIRC, there's a way to reboot the host and have autotest resume
testing when it comes up. I'm almost 100% sure this doesn't work with
current virt-test code, but it would be nice to get it
As usual, we restart libvirtd service to emulate host reboot for this
kinds of testing, in addition, you had better to check whether
$network.xml exists under the /etc/libvirt/$hypervisor/networks/autostart/.
Yes, it's the "...also check XYZ" appendixes why I'm not 100%
comfortable "simulating" reboots. Not only can we get false-PASS, but
we can also get false-FAIL very easy. Remember, this must work across
multiple distro's, the overall variability is probably larger that we
realize.
IMHO, we need to be testing this with a host reboot also since this is
what autostart is designed for. Otherwise, if we run into an issue with
simulated reboot + autostart, engineering will be mad if it is not
reproducible problem on real host reboot.
--
Chris Evich, RHCA, RHCE, RHCDS, RHCSS
Quality Assurance Engineer
e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
