Never mind previous message. I just now read this, so we're in agreement. Bottom line: code in trunk should now fix the issue.
On 9/9/14 11:11 PM, Nathan Kidd wrote: > On 09/09/14 02:59 PM, Nathan Kidd wrote: >> You'll notice that glReadPixels() comments out the emulateColorIndex() >> check. When glReadPixels() is called by VirtualDrawable::readPixels() >> the current context is the *temp* context, so glxCurrentContext()-based >> lookups fail. This means that up to now an attempt to glReadPixels() on >> a remote overlay (if that even works?) would have failed (since >> overlayCurrent() would never be true). > > Thinking about this later, the above does not make sense. ::readPixels > would never have been called in an overlayCurrent() situation (since > overlay is always remote). If the app makes a direct glReadPixels() > call then the current context lookup would have worked. > >> If the format is GL_COLOR_INDEX >> then we'll get GL_INVALID_OPERATION unless the current context/drawable >> is CI. > > Thus, for the new "is current context CI" condition, there is no need to > check. If the format is already specified as CI then at best failing the > "is current context CI" condition would get an error returned. > > Revised bottom line: glReadPixels() should check > ctxhash.overlayCurrent() like it did before. ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk _______________________________________________ VirtualGL-Devel mailing list VirtualGL-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/virtualgl-devel
