On 04/10/14 03:03 AM, DRC wrote: > Note that fakerut tests for all of this. I strongly encourage using the > "servertest" script, which attempts to perform various faker regression > tests using fakerut, including color index rendering tests. Let me know > if you encounter any problems with those tests.
trunk fakerut passes for me. > I made some modifications to your patch Regardless of whether you macro-ized the emulation check for performance of esthetics, the "what compiler wouldn't inline that" train of thought that ensued reminds that these checks are extremely non-performant[1] relative to what the gl function call would be un-modified. So, note to mythical future person that inexplicably wants to use these glIndex functions in a performance-sensitive context: A TLS-based __vgl_isContextOverlay and __vgl_isContextColorIndex set at MakeCurrent time would be a path to avoid that. Meanwhile in the real world nobody cares. > and added a check in fakerut to > test for the condition (i.e. a test that will fail without the patch.) /me makes mental note to try and remember to include fakerut tests in future > Everything is checked into trunk and seems to work. Please re-test it > with MSC Mentat when you get a chance. trunk works fine for me when playing back the trace of MSC Mentat I have. Thanks. -Nathan [1] Bearing in mind that when used millions of times a frame merely adding a few clock cycles significantly impacts performance. ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk _______________________________________________ VirtualGL-Devel mailing list VirtualGL-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/virtualgl-devel
